[Spice-devel] [PATCH][spice-gtk] build-sys: make path to polkit consider prefix.

Uri Lublin uril at redhat.com
Wed Dec 10 07:36:26 PST 2014


On 12/08/2014 09:28 PM, Marc-André Lureau wrote:
> Hi
>
> ----- Original Message -----
>> ---
>>   configure.ac | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index b55f3a0..c150e2f 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -449,7 +449,7 @@ if test "x$have_usbredir" = "xyes" && test
>> "x$enable_polkit" != "xno"; then
>>       AC_DEFINE([USE_POLKIT], [1], [Define if supporting polkit])
>>     fi
>>     AM_CONDITIONAL([WITH_POLKIT], [test "x$have_polkit" = "xyes"])
>> -  POLICYDIR=`${PKG_CONFIG} polkit-gobject-1 --variable=policydir`
>> +  POLICYDIR="${prefix}/`${PKG_CONFIG} polkit-gobject-1
>> --variable=policydir`"
> Hmm, is this going to work?
> $ pkg-config polkit-gobject-1 --variable=policydir
> /usr/share/polkit-1/actions/
>
> Prepending /usr isn't good.
>
> If you want to install out of prefix, you should consider DESTDIR=/tmp/foo make install

Maybe we can replace polkit-prefix with current prefix.
The following pseudo patch was not tested:
  - POLICYDIR=`${PKG_CONFIG} polkit-gobject-1 --variable=policydir`
+ polkit_dir=`${PKG_CONFIG} polkit-gobject-1 --variable=policydir`
+ polkit_prefix =`${PKG_CONFIG} polkit-gobject-1 --variable=prefix`
+ POLICYDIR=`echo ${polkit_dir} | sed ",^${polkit_prefix},${prefix},"

Regards,
     Uri.



More information about the Spice-devel mailing list