[Spice-devel] [PATCH spice-gtk] RFC: populate all clipboards

[Christophe Fergeau]

On Mon, Feb 24, 2014 at 06:33:34AM -0500, Marc-André Lureau wrote:
> > On Thu, Feb 20, 2014 at 04:15:51PM +0100, Marc-André Lureau wrote:
> > > Nevertheless, this is a proof of concept, when setting
> > > SPICE_CLIPBOARD_FILL_ALL=1, all implemented clipboards will be
> > > populated by spice-gtk.
> > 
> > Has this been requested when using linux clients with linux guests? If it's
> > only useful for Windows clients/linux guests, shouldn't we set both
> > selection and clipboard in the linux guest when filling the windows
> > clipboard, and just keep the regular behaviour in all other cases?
> 
> The proposal is to implement SPICE_CLIPBOARD_FILL_ALL=1 that will sync
> all clipboards: keep it simple. I don't fancy more having special cases
> OS / direction.

Well, this env variable really is an "unbreak my app" option, which people
need to know about, so this needs to be documented, this can't be switched
at runtime, ...
I'd just replace the if (g_getenv(...)) {} with some kind of if
(os_is_win32()) which is probably closer to the expected behaviour as
Windows does not have the clipboard/selection distinction.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20140225/c03e953a/attachment.pgp>