[Spice-devel] [PATCH spice-gtk] RFC: populate all clipboards

[Marc-André Lureau]

----- Original Message -----
> On Mon, Feb 24, 2014 at 06:33:34AM -0500, Marc-André Lureau wrote:
> > > On Thu, Feb 20, 2014 at 04:15:51PM +0100, Marc-André Lureau wrote:
> > > > Nevertheless, this is a proof of concept, when setting
> > > > SPICE_CLIPBOARD_FILL_ALL=1, all implemented clipboards will be
> > > > populated by spice-gtk.
> > > 
> > > Has this been requested when using linux clients with linux guests? If
> > > it's
> > > only useful for Windows clients/linux guests, shouldn't we set both
> > > selection and clipboard in the linux guest when filling the windows
> > > clipboard, and just keep the regular behaviour in all other cases?
> > 
> > The proposal is to implement SPICE_CLIPBOARD_FILL_ALL=1 that will sync
> > all clipboards: keep it simple. I don't fancy more having special cases
> > OS / direction.
> 
> Well, this env variable really is an "unbreak my app" option, which people
> need to know about, so this needs to be documented, this can't be switched
> at runtime, ...

I don't think it should be enabled by default. It really breaks some use cases! (like doing regular 2 clipboards manipulations in guests)

This is all wrong, I think we should solve this elsewhere really. Just because we can do something doesn't mean we should do it.

> I'd just replace the if (g_getenv(...)) {} with some kind of if
> (os_is_win32()) which is probably closer to the expected behaviour as
> Windows does not have the clipboard/selection distinction.

Please discuss your proposal in the bug with the reporter/requester. I'll do the same once I figure a different solution that doesn't involve Spice.

> 
> Christophe
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>