[Spice-devel] [PATCH 1/2] build-sys: Require a new enough spice-protocol in .pc file

[Fabiano Fidencio]

----- Original Message -----
> From: "Christophe Fergeau" <cfergeau at redhat.com>
> To: spice-devel at freedesktop.org
> Sent: Friday, August 14, 2015 6:19:01 PM
> Subject: [Spice-devel] [PATCH 1/2] build-sys: Require a new enough	spice-protocol in .pc file
> 
> spice-server headers expose SpiceImageCompression which is only available
> from recent spice-protocol releases.
> This dependency must be expressed in Requires and not Requires.private
> ---
>  configure.ac       | 5 +++--
>  spice-server.pc.in | 1 +
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 5a4c78c..1903384 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -109,8 +109,9 @@ AS_IF([test x"$have_smartcard" = "xyes"], [
>      AS_VAR_APPEND([SPICE_REQUIRES], [" libcacard >= 0.1.2"])
>  ])
>  
> -PKG_CHECK_MODULES([SPICE_PROTOCOL], [spice-protocol >= 0.12.10])
> -AS_VAR_APPEND([SPICE_REQUIRES], [" spice-protocol >= 0.12.10"])
> +SPICE_PROTOCOL_MIN_VER=0.12.10
> +PKG_CHECK_MODULES([SPICE_PROTOCOL], [spice-protocol >=
> $SPICE_PROTOCOL_MIN_VER])
> +AC_SUBST([SPICE_PROTOCOL_MIN_VER])
>  
>  PKG_CHECK_MODULES([GLIB2], [glib-2.0 >= 2.22])
>  AS_VAR_APPEND([SPICE_REQUIRES], [" glib-2.0 >= 2.22"])
> diff --git a/spice-server.pc.in b/spice-server.pc.in
> index f65ddcf..6514c44 100644
> --- a/spice-server.pc.in
> +++ b/spice-server.pc.in
> @@ -7,6 +7,7 @@ Name: spice
>  Description: SPICE server library
>  Version: @VERSION@
>  
> +Requires: spice-protocol >= @SPICE_PROTOCOL_MIN_VER@
>  Requires.private: @SPICE_REQUIRES@
>  Libs: -L${libdir} -lspice-server
>  Libs.private: @SPICE_NONPKGCONFIG_LIBS@
> --
> 2.4.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
> 

ACK both patches!