[Spice-devel] [PATCH 2/2] server: Readd spice-experimental.h

[Marc-André Lureau]

ack

On Fri, Aug 14, 2015 at 6:19 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> Commit 3c6b4e41 removed spice-experimental.h as this header was not
> used, nor supposed to be used. However, QEMU had been including it
> (without using any of its symbols) until commit v2.3.0-rc0~135^2~1
>
> As this is fairly recent (Nov 2014), building older QEMUs with new
> spice-server releases, or even bisecting QEMU will be broken as they
> will be looking for a no-longer available header.
>
> This commit readds a spice-experimental.h file, however it only contains
> a #warning indicating this file is deprecated. This means older QEMU
> will build now, but only if they were configured with --disable-werror.
> ---
>  server/Makefile.am          | 1 +
>  server/spice-experimental.h | 6 ++++++
>  2 files changed, 7 insertions(+)
>  create mode 100644 server/spice-experimental.h
>
> diff --git a/server/Makefile.am b/server/Makefile.am
> index 5fc469a..6ff6917 100644
> --- a/server/Makefile.am
> +++ b/server/Makefile.am
> @@ -52,6 +52,7 @@ libspice_serverinclude_HEADERS =              \
>         spice-audio.h                           \
>         spice-char.h                            \
>         spice-core.h                            \
> +       spice-experimental.h                    \
>         spice-input.h                           \
>         spice-migration.h                       \
>         spice-qxl.h                             \
> diff --git a/server/spice-experimental.h b/server/spice-experimental.h
> new file mode 100644
> index 0000000..ad8abac
> --- /dev/null
> +++ b/server/spice-experimental.h
> @@ -0,0 +1,6 @@
> +#ifndef __SPICE_EXPERIMENTAL_H__
> +#define __SPICE_EXPERIMENTAL_H__
> +
> +#warning spice-experimental.h is deprecated
> +
> +#endif // __SPICE_EXPERIMENTAL_H__
> --
> 2.4.3
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel



-- 
Marc-André Lureau