[Spice-devel] [PATCH spice-gtk RFC] Call spice_marshaller_flush on message write

[Javier Celaya]

Hello

El 15/09/15 a las 17:57, Christophe Fergeau escribió:
> Hey,
>
> On Fri, Jul 31, 2015 at 03:25:32PM +0200, Christophe Fergeau wrote:
>> On Mon, Jul 27, 2015 at 03:06:12PM +0200, Javier Celaya wrote:
>>> spice_marshaller_flush must be called before writing a message to
>>> calculate pointer offsets.
>> Yes, though so far this was not needed as the only ptr marshaller is
>> used for TunnelChannel::service_add message, which spice-gtk does not
>> support. I assume you hit this bug while working on the same code which
>> led to this spice-common/common/marshallers.c fix?
> Any more details as to why this fix is needed?
>
> Christophe
Sorry Christophe, just realized I did not answer your question. We 
needed this patch just for a small experiment, and I forgot about it. It 
is not critical or anything, but it improves correctness. It may save 
some valuable time to anyone implementing a message with pointers and 
wondering why their pointers are NULL at destination ;)
-- 



<http://flexvdi.com><http://flexvdi.com>

Javier Celaya

Software Engineer

	

j <mailto:javier.celaya at flexvdi.com>avier.celaya at flexvdi.com

+34 876 60 00 73

@j_celaya

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151209/3a6ac161/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: logo.flexvdi.png
Type: image/png
Size: 17075 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151209/3a6ac161/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mail.png
Type: image/png
Size: 9350 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151209/3a6ac161/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: phone.png
Type: image/png
Size: 15099 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151209/3a6ac161/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: skype.png
Type: image/png
Size: 14444 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151209/3a6ac161/attachment-0007.png>