[Spice-devel] [common PATCH 1/9 v4] ppc: Always convert surface on BE machine

[Lukas Venhoda]

Hi

On Thu, Dec 17, 2015 at 11:32 AM, Lukas Venhoda <lvenhoda at redhat.com> wrote:

>
> I'm wondering if this could cause issues when blitting transparent
>> surfaces to a 16bpp canvas, as the canvas_get_image_internal documentation
>> mentions this as a usecase (and the only caller with want_original =
>> TRUE is canvas_draw_alpha_blend)
>> (NB: my understanding is that "want_original" really means
>> "keep_original_image_format")
>>
>>
> I'll try to test the 16bpp again on Win7, because WinXP 16bpp had it's own
> weird issues.
> But from what I understand, it shouldn't be an issue, because setting
> want_original to TRUE
> will just convert the canvas to the correct one when using
> canvas_draw_alpha_blend() anyway right?
>

So you were right, when I use this fix with 16bpp on Win7, some areas in
properties windows are black.
I also found out, that this patch is not actually needed, because it's the
other way around.
We always convert, when saved_want_original == FALSE, and on 16bpp we DO
NOT want to convert.

This patch is then not needed, and actually breaks 16bpp on ppc.
Rest should be ok.

-- 
Lukas Venhoda
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151217/6630c2af/attachment-0001.html>