[Spice-devel] [common PATCH 1/9 v4] ppc: Always convert surface on BE machine

[Lukas Venhoda]

Hi

On Fri, Dec 11, 2015 at 2:07 PM, Christophe Fergeau <cfergeau at redhat.com>
wrote:

> Hey,
>
> Rather than having #ifndef everywhere, I think this bit could be changed
> to
> +#ifndef WORDS_BIGENDIAN
>       saved_want_original = want_original;
> +#else
> +        /* On BE machines, we want to explicitly convert the surface all
> the time */
> +     saved_want_original = TRUE;
> +#endif
>
>
Yes, I will change that


> I'm wondering if this could cause issues when blitting transparent
> surfaces to a 16bpp canvas, as the canvas_get_image_internal documentation
> mentions this as a usecase (and the only caller with want_original =
> TRUE is canvas_draw_alpha_blend)
> (NB: my understanding is that "want_original" really means
> "keep_original_image_format")
>
>
I'll try to test the 16bpp again on Win7, because WinXP 16bpp had it's own
weird issues.
But from what I understand, it shouldn't be an issue, because setting
want_original to TRUE
will just convert the canvas to the correct one when using
canvas_draw_alpha_blend() anyway right?


> Christophe
>

-- 
Lukas Venhoda
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151217/e6967be6/attachment.html>