[Spice-devel] [PATCH spice-html5 0/4] Enable file transfer from client to guest

[Jeremy White]

Hi Pavel,

On 01/07/2015 07:16 AM, Pavel Grunt wrote:
> Hi, the intetion of this series is to add the ability to transfer files from the client to the guest.
>
> To make it work it was convenient to start using agent tokens (PATCH 1/4 & 2/4) because there can be a lot of agent messages when sending a file.
> Methods for the transfer are based on relevant methods in spice-gtk.

This looks like a great addition; thanks for doing this work.

I've got a few general questions, and then some specific comments on 
some of the patches.

General questions:  what browsers have you tested this with? 
Ostensibly, spice-html5 works with IE, Firefox and Google, and I'd like 
to maintain that.

Also, what file sizes have you tried?  I have some concern that the 
implementation appears to need to read the whole file into memory.  Do I 
read that right?  That is, it looks like you read all the slices in, and 
then send when tokens are available.  Did you consider an implementation 
that only reads when tokens are available?

I've got more comments on specific patches, which I'll send on each patch.

Cheers,

Jeremy


>
> Pavel Grunt (4):
>    Handle agent tokens
>    Send agent messages only when have agent tokens
>    Implement methods for transfering files from client to guest
>    Use drag and drop for transfering files from client to guest
>
>   enums.js        |   6 +++
>   filexfer.js     |  46 +++++++++++++++++++
>   main.js         | 140 ++++++++++++++++++++++++++++++++++++++++++++++++++++----
>   spice.html      |   8 ++++
>   spice_auto.html |   8 ++++
>   spicemsg.js     | 122 +++++++++++++++++++++++++++++++++++++++++++++++-
>   6 files changed, 320 insertions(+), 10 deletions(-)
>   create mode 100644 filexfer.js
>