[Spice-devel] [PATCH spice-html5 0/4] Enable file transfer from client to guest

[Pavel Grunt]

Hi Jeremy,

Thanks a lot for your feedback.

> 
> Hi Pavel,
> 
> 
> This looks like a great addition; thanks for doing this work.
> 
> I've got a few general questions, and then some specific comments on
> some of the patches.
> 
> General questions:  what browsers have you tested this with?
> Ostensibly, spice-html5 works with IE, Firefox and Google, and I'd
> like
> to maintain that.
> 

It worked in Firefox and Google Chrome, but I was unable to run spice-html5 in IE11 (I guess it was because IE11 does not support MediaSource API).

> Also, what file sizes have you tried?  I have some concern that the
> implementation appears to need to read the whole file into memory.
>  Do I
> read that right?  That is, it looks like you read all the slices in,
> and
> then send when tokens are available.  Did you consider an
> implementation
> that only reads when tokens are available?
> 

I have tried file sizes from few bytes up to 300MB. The approach you described is probably better, I can rewrite it that way.

Best regards,

Pavel