[Spice-devel] [PATCH spice-html5 0/4] Enable file transfer from client to guest

[Pavel Grunt]

Hi,

> 
> Great, thanks.  And yeah, IE support is dicey at best.  I think the
> ideal is that we at least downgrade functionality gracefully, instead
> of
> failing.
> 
> I have been playing with your patches, and they seem to work nicely.
> I'll try to comment more formally on the v3 set.
> 
> My remaining comments have less to do with your patches, than with
> the
> whole process.
> 
> I have to confess I'm pretty ignorant of the whole file transfer
> function.  There are some ways it behaves that seem less than ideal.
> There is no progress bar, I take it?

I can add a progress bar element.

>  And do we really transmit in that small a chunk size? 

Well, I was unable to send bigger than 2kB - maybe it is websockify related problem.
In spice-gtk we are sending 64KB and thanks to it the performance is much better.

> And we preallocate the whole file before filling in the bytes?

It is implemented in spice vdagent that way.

> 
> I worry that the net result is going to be (and is currently)
> potentially confusing.  I drop a 4G file on my browser. Nothing
> happens.
>  I drop it again.  Now I've started a many hour process that's going
>  to run in the background.
> 
I understand that it is confusing - maybe the progress bar can help?

>
> Also, on the file preallocation, I worry that I'll go look, think the
> file is complete (because the size is right), and then copy off a
> corrupt version...
> 
> Do I understand correctly, or have I just horribly mis-configured my
> agent?
> 

You understand it correctly, I will add patches to solve issues.

Best regards,

Pavel