[Spice-devel] RFC - Direct smart card support in libcacard/spice-gtk

[Marc-André Lureau]

Hi

----- Original Message -----
> 
> I've spun up v2 of this discussion patch set.  I struggled for a while;
> I made an attempt to rename the vcard_emul_init entry point, and in the
> end, I felt that it was a pointless ABI change, just to satisfy my need
> to feel that the name made sense.  (I'm bothered that I call an
> xxx_emul_xxx function to use a *non* emulated device).
> 
> Once I got over that, the change actually became fairly atomic, and
> seemed to connect up reasonably well.
> 
> Attached is a v2 that seems like a good approach to me.  Again, I may be
> being myopic.  I did remove the -p (passthru) option from vscclient; you
> can achieve that result with '-e "use_hw=yes hw_type=passthru"', so it
> seemed redundant to me.
> 
> Feedback appreciated.  If it doesn't seem offensive, I will likely
> polish it a bit and submit it properly.

Great! I think this is a better fit, thanks. For a quick glance, the spice-gtk patch looks good, I would try to keep the "smartcard" prefix in options and properties though (--smartcard-type=passthrough?). Please submit the libcacard patch to qemu when you feel ready.

cheers