[Spice-devel] [PATCH xf86-qxl] Remove image cache

[Jonathon Jongsma]

On Fri, 2015-01-30 at 14:07 +0100, Marc-André Lureau wrote:
> On Fri, Jan 30, 2015 at 1:57 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> > Yes, so we are back to my original question, which of its intended
> > purpose is it failing to achieve, and why ? I'm not saying it's not
> > useless or unused, I'm only saying the commit log needs to be more
> > descriptive.
> 
> 
> Well, I suppose it was an "image cache" of some sort, as the name
> suggest, but it isn't anymore, and for a long time it seems.
> So let's please remove this code that is harmful and useless at this point.
> 


How about this: Can you explain why removing the code is a better idea
than simply fixing it? Why is the cache unnecessary? When did it become
unnecessary? You clearly know all of this information since you made the
decision to remove it. We're simply asking for you to help us understand
the rationale by giving a bit more context.

Most of your commits are very light on details of what you changed and
and why. For somebody with a very intimate knowledge of the code, this
is not a big deal. But for somebody investigating old changes in parts
of the code they're not as familiar with, it adds a *lot* of time to try
to understand what was changed and why. 

jonathon