[Spice-devel] [PATCH xf86-qxl] Remove image cache

[Marc-André Lureau]

Hi


On Fri, Jan 30, 2015 at 4:17 PM, Jonathon Jongsma <jjongsma at redhat.com> wrote:
> How about this: Can you explain why removing the code is a better idea
> than simply fixing it? Why is the cache unnecessary? When did it become
> unnecessary? You clearly know all of this information since you made the
> decision to remove it. We're simply asking for you to help us understand
> the rationale by giving a bit more context.
>
> Most of your commits are very light on details of what you changed and
> and why. For somebody with a very intimate knowledge of the code, this
> is not a big deal. But for somebody investigating old changes in parts
> of the code they're not as familiar with, it adds a *lot* of time to try
> to understand what was changed and why.


I am not familiar with this code, I didn't write most of it. But I can
read code and see when things are useless. If you pay a few minutes
reading, you'll probably come to the same conclusion. I can make
speculations on what it was supposed to be, but I don't see the point
here. And I don't have much interest in understanding that either as
of know, all I want is to remove that leak from our code and remove
things that are quite obviously useless!

-- 
Marc-André Lureau