[Spice-devel] [PATCH 3/4] Do not unconditionally send monitor config on agent connect

Jonathon Jongsma jjongsma at redhat.com
Thu Jul 16 14:53:59 PDT 2015


It is not the spice-gtk library's responsibility to automatically send
monitor config messages. That responsibility belongs to the application.
There are some situations where the SpiceDisplay widget automatically
sends monitor config messages, but only if the "resize-guest" property
is set. In other words, there is a way to disable this behavior. But
there is no reason for the library to trigger a monitor configuration
update unconditionally when the vdagent becomes connected. This almost
always results in an unnecessary configuration message being sent to the
server.
---
 src/channel-main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/channel-main.c b/src/channel-main.c
index e4484e3..3b9d5b1 100644
--- a/src/channel-main.c
+++ b/src/channel-main.c
@@ -1947,7 +1947,6 @@ static void main_agent_handle_msg(SpiceChannel *channel,
         }
         c->agent_caps_received = true;
         g_coroutine_signal_emit(self, signals[SPICE_MAIN_AGENT_UPDATE], 0);
-        update_display_timer(SPICE_MAIN_CHANNEL(channel), 0);
 
         if (caps->request)
             agent_announce_caps(self);
-- 
2.1.0



More information about the Spice-devel mailing list