[Spice-devel] [PATCH 3/4] Do not unconditionally send monitor config on agent connect

[Marc-André Lureau]

Hi

----- Original Message -----
> It is not the spice-gtk library's responsibility to automatically send
> monitor config messages. That responsibility belongs to the application.
> There are some situations where the SpiceDisplay widget automatically
> sends monitor config messages, but only if the "resize-guest" property
> is set. In other words, there is a way to disable this behavior. But
> there is no reason for the library to trigger a monitor configuration
> update unconditionally when the vdagent becomes connected. This almost
> always results in an unnecessary configuration message being sent to the
> server.

Shouldn't it send the current config when resize-guest is enabled and
agent is started?

> ---
>  src/channel-main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/channel-main.c b/src/channel-main.c
> index e4484e3..3b9d5b1 100644
> --- a/src/channel-main.c
> +++ b/src/channel-main.c
> @@ -1947,7 +1947,6 @@ static void main_agent_handle_msg(SpiceChannel
> *channel,
>          }
>          c->agent_caps_received = true;
>          g_coroutine_signal_emit(self, signals[SPICE_MAIN_AGENT_UPDATE], 0);
> -        update_display_timer(SPICE_MAIN_CHANNEL(channel), 0);
>  
>          if (caps->request)
>              agent_announce_caps(self);
> --
> 2.1.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>