[Spice-devel] [PATCH spice-gtk v3 3/3] Display: Send a preferred compression message on init.

[Christophe Fergeau]

On Tue, Jun 02, 2015 at 06:04:57PM +0200, Javier Celaya wrote:
> El Martes, 2 de junio de 2015 14:26:58 Christophe Fergeau escribió:
> > I'd deal with the "preferred_compression >=
> > SPICE_IMAGE_COMPRESS_ENUM_END" case with a g_warn_if_fail() as
> > g_param_spec_enum should guarantee that you won't get a value not
> > covered by the registered GEnum.
> > 
> > Christophe
> 
> Then I shouldn't check it at all... After all, there is no check for the other two properties 
> in that function (cache-size and glz-window-size). I would rather remove the 
> "preferred_compression < SPICE_IMAGE_COMPRESS_ENUM_END" condition.-- 

Sure, fine with me.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150603/9728295b/attachment.sig>