[Spice-devel] [PATCH spice-gtk v3 3/3] Display: Send a preferred compression message on init.

[Javier Celaya]

El Martes, 2 de junio de 2015 14:26:58 Christophe Fergeau escribió:
> I'd deal with the "preferred_compression >=
> SPICE_IMAGE_COMPRESS_ENUM_END" case with a g_warn_if_fail() as
> g_param_spec_enum should guarantee that you won't get a value not
> covered by the registered GEnum.
> 
> Christophe

Then I shouldn't check it at all... After all, there is no check for the other two properties 
in that function (cache-size and glz-window-size). I would rather remove the 
"preferred_compression < SPICE_IMAGE_COMPRESS_ENUM_END" condition.-- 


[1] [2]
*Javier Celaya *
/Software Engineer /
[3] j[4]_avier.celaya at flexvdi.com_ 
[5] +34 976 512 433 
[6] @j_celaya 


--------
[1] http://www.flexvdi.com/img/general/logo.flexvdi.png
[2] http://flexvdi.com
[3] http://flexvdi.com/signature/mail.png
[4] mailto:javier.celaya at flexvdi.com
[5] http://flexvdi.com/signature/phone.png
[6] http://flexvdi.com/signature/skype.png
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150602/560a34f2/attachment-0001.html>