[Spice-devel] [PATCH v2 1/3] jhbuildrc: switch default from gtk2 to gtk3

[Victor Toso]

On Tue, May 12, 2015 at 03:34:22PM +0200, Christophe Fergeau wrote:
> On Mon, May 11, 2015 at 09:07:19PM +0200, Victor Toso wrote:
> > Hi,
> > 
> > On Sun, May 10, 2015 at 06:47:31PM +0300, Kirill Moizik wrote:
> > > From: Kirill Moizik <kmoizik at redhat.com>
> > >
> > > change default modules from modules using gtk2 to modules using gtk3
> > 
> > As Fabiano mentioned, the requirements for virt-viewer-gtk3 and
> > virt-viewer (gtk2) could go in the moduleset as buildep. JHBuild would
> > fetch and build them. So one could have gtk2 and gtk3 version by having:
> > modules = [ "virt-viewer", "virt-viewer-gtk3" ]
> 
> I don't exactly get what you are suggesting here. Have
> ""virt-viewer-gtk3" depend on "meta-gtk-osx-gtk3" ?
>

Well, yes. Is it a bad idea?
On linux jhbuild, we can choose gtk2 our gtk3 at build time but on OSX
they are different modules so, including the meta-gtk-osx-gtk3 as
build dep was what I suggested.

> > 
> > > Signed-off-by: Kirill Moizik <kmoizik at redhat.com>
> > > ---
> > >  jhbuildrc | 5 +++--
> > >  1 file changed, 3 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/jhbuildrc b/jhbuildrc
> > > index b1873c3..403ef43 100644
> > > --- a/jhbuildrc
> > > +++ b/jhbuildrc
> > > @@ -9,10 +9,11 @@ prefix = os.path.join(_root, "inst")
> > >  
> > >  # spice gtk-osx moduleset
> > >  moduleset = 'http://cgit.freedesktop.org/~teuf/spice-jhbuild/plain/modulesets/spice.xml?h=osx'
> > 
> > I believe this should point to the local moduleset/spice.xml
> 
> Iirc jhbuild usually defaults to fetching its modulesets from a remote
> location, and you have to explicitly tell it to use the local
> modulesets, this is similar here.
> 
> Christophe

Okay!