[Spice-devel] [PATCH v2 1/3] jhbuildrc: switch default from gtk2 to gtk3

[Christophe Fergeau]

On Tue, May 12, 2015 at 03:48:50PM +0200, Victor Toso wrote:
> On Tue, May 12, 2015 at 03:34:22PM +0200, Christophe Fergeau wrote:
> > On Mon, May 11, 2015 at 09:07:19PM +0200, Victor Toso wrote:
> > > Hi,
> > > 
> > > On Sun, May 10, 2015 at 06:47:31PM +0300, Kirill Moizik wrote:
> > > > From: Kirill Moizik <kmoizik at redhat.com>
> > > >
> > > > change default modules from modules using gtk2 to modules using gtk3
> > > 
> > > As Fabiano mentioned, the requirements for virt-viewer-gtk3 and
> > > virt-viewer (gtk2) could go in the moduleset as buildep. JHBuild would
> > > fetch and build them. So one could have gtk2 and gtk3 version by having:
> > > modules = [ "virt-viewer", "virt-viewer-gtk3" ]
> > 
> > I don't exactly get what you are suggesting here. Have
> > ""virt-viewer-gtk3" depend on "meta-gtk-osx-gtk3" ?
> >
> 
> Well, yes. Is it a bad idea?

No, I was just making sure this was what you were suggesting ;) It's
this way mainly because I copied whatwas in the jhbuildrc sample files
in https://git.gnome.org/browse/gtk-osx/tree/jhbuildrc-gtk-osx#n470
However, modules in this jhbuild moduleset do not seem to have a direct
dependency on meta-gtk-osx, just a <after> <dep ...> </after>, so I'd
tend to do the same for the spice moduleset.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150512/be62189a/attachment-0001.sig>