[Spice-devel] [spice-gtk PATCH v2 4/5] tests: fix leaks from pipes

Victor Toso victortoso at redhat.com
Tue May 19 07:34:36 PDT 2015


==30787== 2,808 (648 direct, 2,160 indirect) bytes in 9 blocks are
definitely lost in loss record 479 of 482
==30787==    at 0x93AEBFD: g_type_create_instance (gtype.c:1849)
==30787==    by 0x939128A: g_object_new_internal (gobject.c:1774)
==30787==    by 0x9392AA0: g_object_newv (gobject.c:1921)
==30787==    by 0x939338B: g_object_new (gobject.c:1614)
==30787==    by 0x403B30: make_gio_pipe (giopipe.c:441)
==30787==    by 0x403C8E: spice_make_pipe (giopipe.c:465)
==30787==    by 0x4029B5: fixture_set_up (pipe.c:42)
==30787==    by 0x9844EC8: test_case_run (gtestutils.c:2123)
==30787==    by 0x9844EC8: g_test_run_suite_internal (gtestutils.c:2185)
==30787==    by 0x984509A: g_test_run_suite_internal (gtestutils.c:2196)
==30787==    by 0x98453FA: g_test_run_suite (gtestutils.c:2249)
==30787==    by 0x9845430: g_test_run (gtestutils.c:1553)
==30787==    by 0x402012: main (pipe.c:312)
---
 tests/pipe.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tests/pipe.c b/tests/pipe.c
index ead8c99..6dbd7cf 100644
--- a/tests/pipe.c
+++ b/tests/pipe.c
@@ -68,6 +68,13 @@ fixture_tear_down(Fixture *fixture,
     g_clear_object(&fixture->p1);
     g_clear_object(&fixture->p2);
 
+    /* The PipeInputStream and PipeOutputStream are not automatically freed
+     * from GIOStream */
+    g_clear_object(&fixture->op1);
+    g_clear_object(&fixture->op2);
+    g_clear_object(&fixture->ip1);
+    g_clear_object(&fixture->ip2);
+
     g_clear_object(&fixture->cancellable);
     g_source_remove(fixture->timeout);
     g_main_loop_unref(fixture->loop);
-- 
2.4.1



More information about the Spice-devel mailing list