[Spice-devel] [spice-gtk PATCH v2 4/5] tests: fix leaks from pipes

Marc-André Lureau marcandre.lureau at gmail.com
Wed May 20 03:58:21 PDT 2015


Hi

On Tue, May 19, 2015 at 4:34 PM, Victor Toso <victortoso at redhat.com> wrote:

> +    /* The PipeInputStream and PipeOutputStream are not automatically
> freed
> +     * from GIOStream */
> +    g_clear_object(&fixture->op1);
> +    g_clear_object(&fixture->op2);
> +    g_clear_object(&fixture->ip1);
> +    g_clear_object(&fixture->ip2);
> +
>

That looks wrong. g_io_stream_get_{in,out}put_stream() do not return
references. The fix should be elsewhere.


-- 
Marc-André Lureau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150520/119fc05c/attachment.html>


More information about the Spice-devel mailing list