[Spice-devel] [client 07/11] build-sys: Allow simultaneous support for Pulse and GStreamer audio

[Christophe Fergeau]

On Tue, Nov 03, 2015 at 01:06:10PM +0100, Francois Gouget wrote:
> Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
> ---
>  configure.ac      | 63 +++++++++++++++++++++++++------------------------------
>  src/Makefile.am   |  4 ++--
>  src/spice-audio.c | 11 +++++-----
>  3 files changed, 37 insertions(+), 41 deletions(-)
> 
> This patch only depends on [client 07/11].
> 
> diff --git a/configure.ac b/configure.ac
> index dea9a30..ddaab2a 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -291,50 +291,44 @@ AS_IF([test "x$have_phodav" = "xyes"],
>  
>  AM_CONDITIONAL([WITH_PHODAV], [test "x$have_phodav" = "xyes"])
>  
> -AC_ARG_WITH([audio],
> -  AS_HELP_STRING([--with-audio=@<:@gstreamer/pulse/auto/no@:>@], [Select audio backend @<:@default=auto@:>@]),
> +AC_ARG_ENABLE([pulse],
> +  AS_HELP_STRING([--enable-pulse=@<:@yes/auto/no@:>@], [Enable the PulseAudio backend @<:@default=auto@:>@]),

Imo it would be a less disruptive change if we changed '--with-audio=auto' to
enable both GStreamer and PulseAudio if the needed .pc files are
available. Removing --with-audio and replacing it with
--enable-pulseaudio/--enable-gstreamer means anyone using --with-audio
will need to update its build scripts.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151106/457fce00/attachment.sig>