[Spice-devel] ovirt-wgt - another attempt

Christophe Fergeau cfergeau at redhat.com
Thu Nov 19 06:03:06 PST 2015


Hey,

On Thu, Nov 19, 2015 at 03:13:35PM +0200, Yedidyah Bar David wrote:
> I find more comfortable this semi-pull-requests mode of operation
> instead of posting patches to the list. Please notify if you prefer me
> to also post, but please use git fetch as it's easier to keep commit
> hashes unchanged if no real change was intended.

Sending just a pull request means that:
- it's not possible to easily send reviews for the individual patches to
  the mailing list. Here I have a minor change I'd like to squash in the
  commit adding the .spec patch, but I cannot easily check with you if
  it's fine. Authorship information is also wrong on 3 other patches (my
  fault), I can fix that before pushing, but cannot easily mention it in
  relation with the patches.

- you are potentially cutting off comments from 'passer-bys' (ie someone
  who is just reading the mailing list but has some insights on one
  particular patch

In short, an easy way to directly fetch the changes to a repository can
be useful, but this cannot really replace sending the individual
patches.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151119/d94d1bff/attachment.sig>


More information about the Spice-devel mailing list