[Spice-devel] [PATCH libcacard 1/3] Include glib.h in public header

[Eduardo Lima (Etrunko)]

On 11/19/2015 01:51 PM, Eduardo Lima (Etrunko) wrote:
> On 11/19/2015 10:30 AM, Marc-André Lureau wrote:
>> vscard_common.h uses glib G_BYTE_ORDER macros. Include glib.h in the
>> file, and thus move glib-2.0 as a Require package.
>>
>> Signed-off-by: Marc-André Lureau <marcandre.lureau at gmail.com>
>> ---
>>  libcacard.pc.in     | 3 ++-
>>  src/vscard_common.h | 1 +
>>  2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/libcacard.pc.in b/libcacard.pc.in
>> index 5bd2b2a..70410e2 100644
>> --- a/libcacard.pc.in
>> +++ b/libcacard.pc.in
>> @@ -6,6 +6,7 @@ includedir=@includedir@
>>  Name: cacard
>>  Description: CA Card library
>>  Version: @PACKAGE_VERSION@
>> -Requires.private: nss glib-2.0
>> +Requires: glib-2.0
> 
> Isn't it also necessary add it as Build-Requires?
> 
> 
Oh sorry, I misread the file, it is on the .pc not .spec. Ignore my low
coffee levels after lunch.

Cheers, Etrunko

-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com