[Spice-devel] [Qemu-devel] [PATCH] [RFC] LZ4 compression option for SPICE

Fabio Fantoni fantonifabio at tiscali.it
Thu Oct 8 23:45:00 PDT 2015


Il 27/01/2015 09:26, Markus Armbruster ha scritto:
> Eric Blake <eblake at redhat.com> writes:
>
>> On 01/26/2015 01:48 AM, Javier Celaya wrote:
>>> Sorry, I forgot to patch the command-line help. Hope it helps.
>>>
>>>>> Recently, SPICE included the lz4 compression algorithm. This patch adds
>>>>> a command line option to select it.
>>>> How is libvirt going to introspect whether the command line supports
>>>> this option?  Is there some QMP command that lists the set of valid
>>>> compression formats understood by a given qemu binary?
>> No, patching the command line --help does NOT help libvirt.  It needs to
>> be discoverable via QMP to be introspectible, as scraping --help output
>> is not machine-friendly.  (That said, you DO want to expose it in --help
>> output; I'm just complaining that --help output alone is not enough).
> We should really, really, really provide access to (the relevant subset
> of) the QAPI schema over QMP!  Until we get that, useful progress is
> delayed by problems like this one, and we keep growing special-purpose
> solutions to problems like this one.
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>

Hi, spice 0.12.6 with lz4 support has been released, is there any
possibility to add it also in qemu upstream to make possible selecting
it "Out of the box" please?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4317 bytes
Desc: Firma crittografica S/MIME
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151009/6096a25d/attachment.bin>


More information about the Spice-devel mailing list