[Spice-devel] [PATCH 2/2] do not link spice with libcacard

[Christophe Fergeau]

On Fri, Oct 09, 2015 at 07:32:33PM +0300, Michael Tokarev wrote:
> Well, not exactly.  Why don't you keep the variables in the final
> SPICE_COMMON_{CFLAGS,LIBS} line my first patch does, instead of
> expanding the values at configure time?  This way it will be possible
> to override the components in a common way at make time.  I'm referring
> to the first hunk, below:

Right, forgot about this, I don't mind at all either way, for my use
cases it's all the same (but I understand what you want to achieve)
> > +SPICE_COMMON_CFLAGS="$PIXMAN_CFLAGS $SMARTCARD_CFLAGS $CELT051_CFLAGS $GLIB2_CFLAGS $OPUS_CFLAGS $GL_CFLAGS"
> > +SPICE_COMMON_LIBS="$PIXMAN_LIBS $CELT051_LIBS $GLIB2_LIBS $OPUS_LIBS $GL_LIBS"
> 
> Why not use
> 
>  +SPICE_COMMON_CFLAGS='$(PIXMAN_CFLAGS) $(SMARTCARD_CFLAGS) $(CELT051_CFLAGS) $(GLIB2_CFLAGS) $(OPUS_CFLAGS) $(GL_CFLAGS)'
>  +SPICE_COMMON_LIBS='$(PIXMAN_LIBS) $(CELT051_LIBS) $(GLIB2_LIBS) $(OPUS_LIBS) $(GL_LIBS)'
> 
> ?
> 
> SPICE_CHECK_PIXMAN et al will use AC_DEFINE(PIXMAN_{CFLAGS,LIBS}), so these
> will be included in the final Makefile, and these are used in server/
> correctly, server/ allows to override these.  But not spice-common.

I'll send a new version with that in.

Christophe

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151013/fb6c4ab6/attachment-0001.sig>