[Spice-devel] [PATCH 11/12] build-sys: move G_LOG_DOMAIN to CPPFLAGS

Christophe Fergeau cfergeau at redhat.com
Fri Oct 9 07:49:10 PDT 2015


On Thu, Oct 08, 2015 at 05:40:40PM +0200, marcandre.lureau at redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau at redhat.com>
> 
> So the whole project use the same log domain.

Any idea why G_LOG_DOMAIN traditionally does not go in
configure.ac/config.h instead of being added to CFLAGS?

ACK patch.

Christophe

> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
> ---
>  Makefile.am   | 1 +
>  src/vreader.c | 5 -----
>  2 files changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index b8e8a90..1cef1ee 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -70,6 +70,7 @@ tests_libcacard_LDADD = libcacard.la
>  @CODE_COVERAGE_RULES@
>  
>  AM_CPPFLAGS =					\
> +	-DG_LOG_DOMAIN=\"libcacard\"		\
>  	$(CACARD_CFLAGS)			\
>  	$(CODE_COVERAGE_CFLAGS)			\
>  	$(PCSC_CFLAGS)				\
> diff --git a/src/vreader.c b/src/vreader.c
> index bd662ac..2d8aa9f 100644
> --- a/src/vreader.c
> +++ b/src/vreader.c
> @@ -5,11 +5,6 @@
>   * See the COPYING file in the top-level directory.
>   */
>  
> -#ifdef G_LOG_DOMAIN
> -#undef G_LOG_DOMAIN
> -#endif
> -#define G_LOG_DOMAIN "libcacard"
> -
>  #include "glib-compat.h"
>  
>  #include <string.h>
> -- 
> 2.4.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151009/4e057119/attachment.sig>


More information about the Spice-devel mailing list