[Spice-devel] [PATCH 11/12] build-sys: move G_LOG_DOMAIN to CPPFLAGS
Marc-André Lureau
mlureau at redhat.com
Fri Oct 9 08:04:44 PDT 2015
----- Original Message -----
> On Thu, Oct 08, 2015 at 05:40:40PM +0200, marcandre.lureau at redhat.com wrote:
> > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> >
> > So the whole project use the same log domain.
>
> Any idea why G_LOG_DOMAIN traditionally does not go in
> configure.ac/config.h instead of being added to CFLAGS?
I think it depends if you have the same for the whole source tree.
Also adding it too early in configure may change it for some checks I suppose.
> ACK patch.
>
> Christophe
>
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
> > ---
> > Makefile.am | 1 +
> > src/vreader.c | 5 -----
> > 2 files changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/Makefile.am b/Makefile.am
> > index b8e8a90..1cef1ee 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -70,6 +70,7 @@ tests_libcacard_LDADD = libcacard.la
> > @CODE_COVERAGE_RULES@
> >
> > AM_CPPFLAGS = \
> > + -DG_LOG_DOMAIN=\"libcacard\" \
> > $(CACARD_CFLAGS) \
> > $(CODE_COVERAGE_CFLAGS) \
> > $(PCSC_CFLAGS) \
> > diff --git a/src/vreader.c b/src/vreader.c
> > index bd662ac..2d8aa9f 100644
> > --- a/src/vreader.c
> > +++ b/src/vreader.c
> > @@ -5,11 +5,6 @@
> > * See the COPYING file in the top-level directory.
> > */
> >
> > -#ifdef G_LOG_DOMAIN
> > -#undef G_LOG_DOMAIN
> > -#endif
> > -#define G_LOG_DOMAIN "libcacard"
> > -
> > #include "glib-compat.h"
> >
> > #include <string.h>
> > --
> > 2.4.3
> >
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/spice-devel
>
More information about the Spice-devel
mailing list