[Spice-devel] [PATCH] Adding new ioctl for updating Vdagent state

Christophe Fergeau cfergeau at redhat.com
Thu Aug 4 12:17:02 UTC 2016


On Thu, Aug 04, 2016 at 02:02:08PM +0300, Sameeh Jubran wrote:
> New ioctl for updating the driver with vdagent running state.

Please add some rationale to the commit log for having this (ie what is
going to be achieved with that escape).

For what it's worth, I don't think the QXL driver should need to know
whether we are in server mode or not (which does not necessarily
correspond to vdagent running/not running). I'm talking about server
mode here as I think you added that in order to fix issues with the
pointer not showing up in server mode.

I believe this issue is not limited to Win8+, and I've seen that too
on linux. Showing/not showing the cursor in server mode is handled
mostly client side. The client gets 'move' events from the server,
and in response to that, blends the server-side cursor. Currently,
I'm not getting these 'move' events regardless of the OS. Could this
patch be meant to address such a bug too, or is this fixing something
else?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160804/e6fa3aa5/attachment-0001.sig>


More information about the Spice-devel mailing list