[Spice-devel] [PATCH] Adding new ioctl for updating Vdagent state

Sameeh Jubran sameeh at daynix.com
Mon Aug 8 15:19:41 UTC 2016


Hi,

This patch fixes the issue with pointer not showing up in server mode, when
vdagent is off.

On Thu, Aug 4, 2016 at 3:17 PM, Christophe Fergeau <cfergeau at redhat.com>
wrote:

> On Thu, Aug 04, 2016 at 02:02:08PM +0300, Sameeh Jubran wrote:
> > New ioctl for updating the driver with vdagent running state.
>
> Please add some rationale to the commit log for having this (ie what is
> going to be achieved with that escape).
>
> For what it's worth, I don't think the QXL driver should need to know
> whether we are in server mode or not (which does not necessarily
> correspond to vdagent running/not running). I'm talking about server
> mode here as I think you added that in order to fix issues with the
> pointer not showing up in server mode.
>
> I believe this issue is not limited to Win8+, and I've seen that too
> on linux. Showing/not showing the cursor in server mode is handled
> mostly client side. The client gets 'move' events from the server,
> and in response to that, blends the server-side cursor. Currently,
> I'm not getting these 'move' events regardless of the OS. Could this
> patch be meant to address such a bug too, or is this fixing something
> else?
>
This patch enables the driver to send move commands to the QXL device when
vdagent is off.
This maybe the reason you are not getting any move commands.

>
> Christophe
>



-- 
Respectfully,
*Sameeh Jubran*
*Linkedin <https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a>*
*Junior Software Engineer @ Daynix <http://www.daynix.com>.*
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160808/441f01db/attachment.html>


More information about the Spice-devel mailing list