[Spice-devel] [PATCH spice-gtk 1/2] Improve file transfer error messages

[Jonathon Jongsma]

On Fri, 2016-08-12 at 04:08 -0400, Frediano Ziglio wrote:
> > 
> > 
> > In preparation for potentially displaying error messages to a user
> > in a
> > UI, I thought I'd improve the messages slightly.
> > ---
> >  src/channel-main.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/src/channel-main.c b/src/channel-main.c
> > index a074928..1ea0f71 100644
> > --- a/src/channel-main.c
> > +++ b/src/channel-main.c
> > @@ -1854,11 +1854,11 @@ static void
> > main_agent_handle_xfer_status(SpiceMainChannel *channel,
> >          return;
> >      case VD_AGENT_FILE_XFER_STATUS_CANCELLED:
> >          error = g_error_new(SPICE_CLIENT_ERROR,
> > SPICE_CLIENT_ERROR_FAILED,
> > -                            "transfer is cancelled by spice
> > agent");
> > +                            "The spice agent cancelled the file
> > transfer");
> >          break;
> >      case VD_AGENT_FILE_XFER_STATUS_ERROR:
> >          error = g_error_new(SPICE_CLIENT_ERROR,
> > SPICE_CLIENT_ERROR_FAILED,
> > -                            "some errors occurred in the spice
> > agent");
> > +                            "The spice agent reported an error
> > during the
> > file transfer");
> >          break;
> >      case VD_AGENT_FILE_XFER_STATUS_SUCCESS:
> >          break;
> 
> Errors are surely better.
> Not sure about capital letter but I don't think will hurt.
> 
> Acked-by: Frediano Ziglio <fziglio at redhat.com>
> 
> Just a consideration... what about internationalization?
> Are we going to use gettext? I hope to.

Hmm, I could have sworn that when I made this change, these messages
were already being translated, but I must have been imagining it. I'll
send a new patch.


> 
> Frediano