[Spice-devel] [PATCH spice-gtk v2] Improve file transfer error messages

Jonathon Jongsma jjongsma at redhat.com
Fri Aug 12 19:54:51 UTC 2016


Oops, I just noticed that Frediano apparently already pushed my old
patch to git master.


On Fri, 2016-08-12 at 14:49 -0500, Jonathon Jongsma wrote:
> In preparation for potentially displaying error messages to a user in
> a
> UI, I thought I'd improve the messages slightly. Also translate them.
> ---
> 
> Changes since v1:
>  - translate messages
> 
>  po/POTFILES.in     | 1 +
>  src/channel-main.c | 5 +++--
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/po/POTFILES.in b/po/POTFILES.in
> index ad12609..db42281 100644
> --- a/po/POTFILES.in
> +++ b/po/POTFILES.in
> @@ -1,3 +1,4 @@
> +src/channel-main.c
>  src/channel-usbredir.c
>  src/desktop-integration.c
>  src/spice-channel.c
> diff --git a/src/channel-main.c b/src/channel-main.c
> index a074928..02817a9 100644
> --- a/src/channel-main.c
> +++ b/src/channel-main.c
> @@ -20,6 +20,7 @@
>  #include <math.h>
>  #include <spice/vd_agent.h>
>  #include <glib/gstdio.h>
> +#include <glib/gi18n.h>
>  
>  #include "spice-client.h"
>  #include "spice-common.h"
> @@ -1854,11 +1855,11 @@ static void
> main_agent_handle_xfer_status(SpiceMainChannel *channel,
>          return;
>      case VD_AGENT_FILE_XFER_STATUS_CANCELLED:
>          error = g_error_new(SPICE_CLIENT_ERROR,
> SPICE_CLIENT_ERROR_FAILED,
> -                            "transfer is cancelled by spice agent");
> +                            _("The spice agent cancelled the file
> transfer"));
>          break;
>      case VD_AGENT_FILE_XFER_STATUS_ERROR:
>          error = g_error_new(SPICE_CLIENT_ERROR,
> SPICE_CLIENT_ERROR_FAILED,
> -                            "some errors occurred in the spice
> agent");
> +                            _("The spice agent reported an error
> during the file transfer"));
>          break;
>      case VD_AGENT_FILE_XFER_STATUS_SUCCESS:
>          break;


More information about the Spice-devel mailing list