[Spice-devel] [PATCH v4 04/17] sound: Rename SndWorker to SndChannel

Frediano Ziglio fziglio at redhat.com
Thu Dec 1 16:47:15 UTC 2016


> 
> On Thu, Dec 01, 2016 at 11:24:26AM +0000, Frediano Ziglio wrote:
> > @@ -1506,73 +1506,73 @@ static void remove_worker(SndWorker *worker)
> >  
> >  void snd_attach_playback(RedsState *reds, SpicePlaybackInstance *sin)
> >  {
> > -    SndWorker *playback_worker;
> > -    RedChannel *channel;
> > +    SndChannel *playback;
> > +    RedChannel *red_channel;
> 
> Here s/channel/red_channel was not really necessary as the other
> variable is named "playback" and not channel, ditto in snd_attach_record
> below.
> 

Should I revert them?

> Acked-by: Christophe Fergeau <cfergeau at redhat.com>
> 
> Christophe

Frediano


More information about the Spice-devel mailing list