[Spice-devel] [PATCH v4 04/17] sound: Rename SndWorker to SndChannel

[Christophe Fergeau]

On Thu, Dec 01, 2016 at 11:47:15AM -0500, Frediano Ziglio wrote:
> > 
> > On Thu, Dec 01, 2016 at 11:24:26AM +0000, Frediano Ziglio wrote:
> > > @@ -1506,73 +1506,73 @@ static void remove_worker(SndWorker *worker)
> > >  
> > >  void snd_attach_playback(RedsState *reds, SpicePlaybackInstance *sin)
> > >  {
> > > -    SndWorker *playback_worker;
> > > -    RedChannel *channel;
> > > +    SndChannel *playback;
> > > +    RedChannel *red_channel;
> > 
> > Here s/channel/red_channel was not really necessary as the other
> > variable is named "playback" and not channel, ditto in snd_attach_record
> > below.
> > 
> 
> Should I revert them?

I'm fine with both options, so as you prefer :)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20161201/dc990534/attachment.sig>