[Spice-devel] [spice v1 1/2] display-channel: reuse function to set video codecs

[Frediano Ziglio]

> From: Victor Toso <me at victortoso.com>
> 
> display_channel_set_video_codecs() already exists.
> 
> Signed-off-by: Victor Toso <victortoso at redhat.com>
> ---
>  server/display-channel.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/server/display-channel.c b/server/display-channel.c
> index 52f0a3d..2d475d1 100644
> --- a/server/display-channel.c
> +++ b/server/display-channel.c
> @@ -62,10 +62,7 @@ display_channel_set_property(GObject *object,
>              self->priv->n_surfaces = g_value_get_uint(value);
>              break;
>          case PROP_VIDEO_CODECS:
> -            if (self->priv->video_codecs) {
> -                g_array_unref(self->priv->video_codecs);
> -            }
> -            self->priv->video_codecs =
> g_array_ref(g_value_get_boxed(value));
> +            display_channel_set_video_codecs(self,
> g_value_get_boxed(value));
>              break;
>          default:
>              G_OBJECT_WARN_INVALID_PROPERTY_ID(object, property_id, pspec);

Not exactly the same. display_channel_set_video_codecs has not the check
for video_codes NULL. This should generate a warning that currently you
don't have.

Frediano