[Spice-devel] [spice v1 2/2] display-channel: Make video-codecs readwrite

[Christophe Fergeau]

On Fri, Dec 02, 2016 at 06:37:26PM +0100, Victor Toso wrote:
> > I prefer accessors.
> 
> Should I drop also the change from G_PARAM_WRITABLE to
> G_PARAM_READWRITE or should I drop the patch entirely?

You can go with both :)

> 
> > Also streaming code should have access to this information, in all
> > other DisplayChannel code video_codecs are useless.
> > That is the problem is that stream data are in DisplayChannel,
> > I think the right direction is encapsulate correctly stream code,
> > data related to stream should be in a "stream" structure.
> >
> > Frediano
> 
> Indeed, it seems that it can be improved but I'm not sure how it should
> be designed?
> 
> Nowadays:
> 
> host calls reds:spice_server_set_video_codecs() that calls
> reds_on_vc_change() which end up sending

Fwiw, method named reds_on_yyy() might be good candidate for using a
signal rather than a function call now that we have more GObjects.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20161205/c9ae5013/attachment.sig>