[Spice-devel] [vd-agent-win32 0/2] Add support for WDDM driver

[Fabio Fantoni]

Il 04/02/2016 17:01, Javier Celaya ha scritto:
>
>
> El 04/02/16 a las 16:59, Javier Celaya escribió:
>> Hi
>>
>> El 04/02/16 a las 15:12, Fabio Fantoni escribió:
>>> Il 04/02/2016 13:31, Javier Celaya ha scritto:
>>>> This patch set adds support for dynamic resolution changes with the WDDM
>>>> driver on Windows >= 8. It is based on the one sent by Vadim Rozenfeld
>>>> with some improvements:
>>>>
>>>> - It detects both the XDDM driver and the WDDM driver, and uses the
>>>>   correct API.
>>>> - It detects if the client is trying to set the same resolution again,
>>>>   and does nothing. This is the result of the client detecting a primary
>>>>   surface destruction/construction when the resolution changes, and
>>>>   asking for a resolution change again. This bug does not happen with
>>>>   the XDDM driver, so it may be avoidable in some other way.
>>>> - It uses an alternative method to update the list of display modes,
>>>>   that results in a nicer effect when changing the resolution. This
>>>>   method is compatible with the current driver implementation (v0.12),
>>>>   but for best results we have modified the driver to drop the previous
>>>>   method and to improve support of hardware pointers. The source can be
>>>>   found in https://github.com/flexvdi/qxl-dod, and precompiled and signed
>>>>   binaries can be downloaded from http://depot.flexvdi.com/guest-tools/.
>>> Big thanks for help improving windows>=8 support (unfortunately still
>>> overlooked).
>>> I want do a fast test to see is your changes solve the bugs (and/or
>>> occasional hangs) I have found trying spice-guest-tools 0.100 and
>>> qxlwddm-0.12.zip on windows 10 guests. For tests your improvements I can
>>> simply install spice-guest-tools.exe inside
>>> flexvdi-guest-tools-2.2.3.exe and qxlwddm-0.13-flexvdi.zip?
>> You can just install spice-guest-tools.exe, as it includes both the
>> patched vdagent.exe and the new driver.
> Actually, I suspect you will have tu uninstall the previous driver
> first, as I forgot to increase the version number and Windows will
> probably say that the driver is already up to date.

Thanks, I did some fast tests with them.
The resolution change seems better, I tried all possible cases and now
worked correctly always.
The mouse seems better, mainly in case of high load when before was near
unusable.
About the occasional windows freeze I don't know if is solved, for now
with your build wasn't happen.
I not found any regression.

I have enough knowledge to review the code, can someone review it for
upstream please?

>>> Thanks for any reply and sorry for my bad english.
>>>
>>>> Javier Celaya (2):
>>>>   Detect and use the new WDDM driver
>>>>   Use CCD API to update the WDDM display modes.
>>>>
>>>>  common/vdcommon.h          | 106 ++++++++++++++++++++++++++++++
>>>>  vdagent/desktop_layout.cpp | 156 +++++++++++++++++++++++++++++++++++++++++----
>>>>  2 files changed, 250 insertions(+), 12 deletions(-)
>>>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160210/2299f580/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4317 bytes
Desc: Firma crittografica S/MIME
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160210/2299f580/attachment-0001.bin>