[Spice-devel] [PATCH 14/14] Add strings for translation

Christophe Fergeau cfergeau at redhat.com
Tue Jan 19 00:59:18 PST 2016


On Mon, Jan 18, 2016 at 02:41:42PM -0600, Jonathon Jongsma wrote:
> On Mon, 2016-01-18 at 10:05 +0100, Fabiano FidĂȘncio wrote:
> > @@ -995,7 +997,7 @@ static void complete_task(SpicePulse *pulse, struct
> > async_task *task, const gcha
> >          g_task_return_new_error(task->task,
> >                                  SPICE_CLIENT_ERROR,
> >                                  SPICE_CLIENT_ERROR_FAILED,
> > -                                "restore-info failed due %s",
> > +                                _("restore-info failed due %s"),
> 
> 
> As long as you're making a change here, it might be good to change this to "due
> to %s" instead of "due %s"? Or maybe a different wording would be better,
> depending on what "err_msg" holds...

I'm also not sure this kind of string concatenation is going to work
very well translation-wise. "restore-info failed due to " may need to
be translated slightly differently depending on what %s actually is.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20160119/b4e08252/attachment.sig>


More information about the Spice-devel mailing list