[Spice-devel] [PATCH 14/14] Add strings for translation

[Jonathon Jongsma]

On Tue, 2016-01-19 at 09:59 +0100, Christophe Fergeau wrote:
> On Mon, Jan 18, 2016 at 02:41:42PM -0600, Jonathon Jongsma wrote:
> > On Mon, 2016-01-18 at 10:05 +0100, Fabiano Fidêncio wrote:
> > > @@ -995,7 +997,7 @@ static void complete_task(SpicePulse *pulse, struct
> > > async_task *task, const gcha
> > >          g_task_return_new_error(task->task,
> > >                                  SPICE_CLIENT_ERROR,
> > >                                  SPICE_CLIENT_ERROR_FAILED,
> > > -                                "restore-info failed due %s",
> > > +                                _("restore-info failed due %s"),
> > 
> > 
> > As long as you're making a change here, it might be good to change this to
> > "due
> > to %s" instead of "due %s"? Or maybe a different wording would be better,
> > depending on what "err_msg" holds...
> 
> I'm also not sure this kind of string concatenation is going to work
> very well translation-wise. "restore-info failed due to " may need to
> be translated slightly differently depending on what %s actually is.
> 
> Christophe


Yeah, in general I get the feeling that most of the error messages in this patch
were not really designed to be user-visible. They tend to be fairly terse and
refer to implementation details that might not be particularly understandable to
a user.  

Jonathon