[Spice-devel] [PATCH 08/14] spice-pulse: Use GTask instead of GSimpleAsyncResult

Christophe Fergeau cfergeau at redhat.com
Wed Jan 20 07:21:28 PST 2016


On Wed, Jan 20, 2016 at 04:09:44PM +0100, Fabiano FidĂȘncio wrote:
> >>  static void spice_pulse_complete_async_task(struct async_task *task, const gchar *err_msg)
> >> @@ -1157,19 +1143,13 @@ static void pulse_stream_restore_info_async(gboolean is_playback,
> >>                                              gpointer user_data)
> >>  {
> >>      SpicePulsePrivate *p = SPICE_PULSE(audio)->priv;
> >> -    GSimpleAsyncResult *simple;
> >> +    GTask *res;
> >
> > Usually you call it 'task' in this series, not 'res'
> 
> Yep. But take a look on line below this one. 'task' is already being used.
> If you prefer, I can change it to 'task' and also change the 'task' to
> something else ....

Ah right. Yeah, don't bother with more renaming :)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20160120/69154a51/attachment.sig>


More information about the Spice-devel mailing list