[Spice-devel] [PATCH 08/14] spice-pulse: Use GTask instead of GSimpleAsyncResult

Jonathon Jongsma jjongsma at redhat.com
Wed Jan 20 08:37:33 PST 2016


On Wed, 2016-01-20 at 16:21 +0100, Christophe Fergeau wrote:
> On Wed, Jan 20, 2016 at 04:09:44PM +0100, Fabiano FidĂȘncio wrote:
> > > >  static void spice_pulse_complete_async_task(struct async_task *task,
> > > > const gchar *err_msg)
> > > > @@ -1157,19 +1143,13 @@ static void
> > > > pulse_stream_restore_info_async(gboolean is_playback,
> > > >                                              gpointer user_data)
> > > >  {
> > > >      SpicePulsePrivate *p = SPICE_PULSE(audio)->priv;
> > > > -    GSimpleAsyncResult *simple;
> > > > +    GTask *res;
> > > 
> > > Usually you call it 'task' in this series, not 'res'
> > 
> > Yep. But take a look on line below this one. 'task' is already being used.
> > If you prefer, I can change it to 'task' and also change the 'task' to
> > something else ....
> 
> Ah right. Yeah, don't bother with more renaming :)

or use "gtask"? 

> 
> Christophe
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel


More information about the Spice-devel mailing list