[Spice-devel] [PATCH] typo: use #ifdef instead of #if
Pavel Grunt
pgrunt at redhat.com
Fri Jan 22 02:27:37 PST 2016
On Fri, 2016-01-22 at 10:59 +0100, Fabiano Fidêncio wrote:
> This typo was introduced by commit 5166f891e and unfortunately was
> not
> caught during the review.
I did not consider it wrong, we have '#if USE_SMARTCARD' on one place
and "USE_*" is always defined with 1 as the value.
I don't have a strong opinion about it, but if you wish to change it to
ifdef, do it for smartcard too.
Thanks,
Pavel
> ---
> src/usb-device-manager.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c
> index 647edd0..6e12602 100644
> --- a/src/usb-device-manager.c
> +++ b/src/usb-device-manager.c
> @@ -393,7 +393,7 @@ static void
> spice_usb_device_manager_get_property(GObject *gobject,
> break;
> case PROP_FREE_CHANNELS: {
> int free_channels = 0;
> -#if USE_USBREDIR
> +#ifdef USE_USBREDIR
> int i;
> for (i = 0; i < priv->channels->len; i++) {
> SpiceUsbredirChannel *channel = g_ptr_array_index(priv-
> >channels, i);
More information about the Spice-devel
mailing list