[Spice-devel] [PATCH] typo: use #ifdef instead of #if

Fabiano FidĂȘncio fabiano at fidencio.org
Fri Jan 22 02:54:24 PST 2016


On Fri, Jan 22, 2016 at 11:27 AM, Pavel Grunt <pgrunt at redhat.com> wrote:
> On Fri, 2016-01-22 at 10:59 +0100, Fabiano FidĂȘncio wrote:
>> This typo was introduced by commit 5166f891e and unfortunately was
>> not
>> caught during the review.
>
> I did not consider it wrong, we have '#if USE_SMARTCARD' on one place
> and "USE_*" is always defined with 1 as the value.
>
> I don't have a strong opinion about it, but if you wish to change it to
> ifdef, do it for smartcard too.

We have more cases like this in channel-usbredir.c as well.

I'll leave it as it is for now and wait for more comments before
taking any action.

Best Regards,
--
Fabiano FidĂȘncio


More information about the Spice-devel mailing list