[Spice-devel] [PATCH] Revert "Disable IME to allow receiving all keys"

Frediano Ziglio fziglio at redhat.com
Thu Jun 16 15:09:37 UTC 2016


This reverts commit 191f9a8ab49f56aa48781b5eeaa4a1a65d626627.

This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1342984.

Calling ImmDisableIME disable IME for the entire program.
On Windows 7 this also hide the keyboard application from the task bar
making impossible to switch keyboard while using remote viewer.
A recent commit in spice-gtk (7d881d2193bf5598b888a48bb4d8d7ad2e62f443,
"widget: Disable IME context on display widget") disable IME processing
just for SpiceDisplay. This avoid the above regression on Windows 7.

Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
---
 src/virt-viewer-util.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/src/virt-viewer-util.c b/src/virt-viewer-util.c
index ebe039c..069586a 100644
--- a/src/virt-viewer-util.c
+++ b/src/virt-viewer-util.c
@@ -30,7 +30,6 @@
 #ifdef G_OS_WIN32
 #include <windows.h>
 #include <io.h>
-#include <imm.h>
 #endif
 
 #include <sys/types.h>
@@ -295,12 +294,6 @@ void virt_viewer_util_init(const char *appname)
             dup2(fileno(stderr), STDERR_FILENO);
         }
     }
-
-    /* Disable input method handling so that the Zenkaku_Hankaku can be passed
-     * to VMs rather than being captured by Windows.
-     * https://bugzilla.redhat.com/show_bug.cgi?id=1297640
-     */
-    ImmDisableIME(-1);
 #endif
 
     setlocale(LC_ALL, "");
-- 
2.7.4



More information about the Spice-devel mailing list