[Spice-devel] [virt-tools-list] [PATCH] Revert "Disable IME to allow receiving all keys"

[Christophe Fergeau]

On Thu, Jun 16, 2016 at 04:09:37PM +0100, Frediano Ziglio wrote:
> This reverts commit 191f9a8ab49f56aa48781b5eeaa4a1a65d626627.
> 
> This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1342984.
> 
> Calling ImmDisableIME disable IME for the entire program.
> On Windows 7 this also hide the keyboard application from the task bar
> making impossible to switch keyboard while using remote viewer.
> A recent commit in spice-gtk (7d881d2193bf5598b888a48bb4d8d7ad2e62f443,
> "widget: Disable IME context on display widget") disable IME processing
> just for SpiceDisplay. This avoid the above regression on Windows 7.

Acked-by: Christophe Fergeau <cfergeau at redhat.com>

Not having this spice-gtk commit is not going to cause a huge
regression, so it's fine not to add strong coupling between this commit
and the spice-gtk commit which fixes this differently.

Christophe


> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  src/virt-viewer-util.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/src/virt-viewer-util.c b/src/virt-viewer-util.c
> index ebe039c..069586a 100644
> --- a/src/virt-viewer-util.c
> +++ b/src/virt-viewer-util.c
> @@ -30,7 +30,6 @@
>  #ifdef G_OS_WIN32
>  #include <windows.h>
>  #include <io.h>
> -#include <imm.h>
>  #endif
>  
>  #include <sys/types.h>
> @@ -295,12 +294,6 @@ void virt_viewer_util_init(const char *appname)
>              dup2(fileno(stderr), STDERR_FILENO);
>          }
>      }
> -
> -    /* Disable input method handling so that the Zenkaku_Hankaku can be passed
> -     * to VMs rather than being captured by Windows.
> -     * https://bugzilla.redhat.com/show_bug.cgi?id=1297640
> -     */
> -    ImmDisableIME(-1);
>  #endif
>  
>      setlocale(LC_ALL, "");
> -- 
> 2.7.4
> 
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160616/18ccab32/attachment.sig>