[Spice-devel] [PATCH v3 2/2] Lower gtk+ requirement to 3.10

Jeremy White jwhite at codeweavers.com
Mon Mar 21 18:28:13 UTC 2016


Hi,

> diff --git a/src/spice-widget-egl.c b/src/spice-widget-egl.c
> index 1b3cd07..a9bea52 100644
> --- a/src/spice-widget-egl.c
> +++ b/src/spice-widget-egl.c
> @@ -29,7 +29,9 @@
>  #include <libdrm/drm_fourcc.h>
>  
>  #include <gdk/gdkx.h>
> +#if GTK_CHECK_VERSION(3,16,0)
>  #include <gdk/gdkwayland.h>
> +#endif

This breaks builds on Debian, which has 3.14.  You get a failure on line
208 because GDK_IS_WAYLAND_DISPLAY is not defined.

I was able to get it to compile by changing this particular #ifdef to
just be
  #ifdef GDK_WINDOWING_WAYLAND

It's not clear if that's right, or if it would be better to make all use
of Wayland conditional on 3,16.

Cheers,

Jeremy


More information about the Spice-devel mailing list