[Spice-devel] [PATCH v3 2/2] Lower gtk+ requirement to 3.10

[Marc-André Lureau]

Hi

----- Original Message -----
> Hi,
> 
> > diff --git a/src/spice-widget-egl.c b/src/spice-widget-egl.c
> > index 1b3cd07..a9bea52 100644
> > --- a/src/spice-widget-egl.c
> > +++ b/src/spice-widget-egl.c
> > @@ -29,7 +29,9 @@
> >  #include <libdrm/drm_fourcc.h>
> >  
> >  #include <gdk/gdkx.h>
> > +#if GTK_CHECK_VERSION(3,16,0)
> >  #include <gdk/gdkwayland.h>
> > +#endif
> 
> This breaks builds on Debian, which has 3.14.  You get a failure on line
> 208 because GDK_IS_WAYLAND_DISPLAY is not defined.
> 
> I was able to get it to compile by changing this particular #ifdef to
> just be
>   #ifdef GDK_WINDOWING_WAYLAND

I think that makes sense. It's defined in gdkconfig.h which is included by gdk.h. As long as it compiles on 3.10, it is good enough. Would you like to send a patch?

> 
> It's not clear if that's right, or if it would be better to make all use
> of Wayland conditional on 3,16.
> 
> Cheers,
> 
> Jeremy
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
>