[Spice-devel] [PATCH spice-gtk v2 6/8] egl: check and update scanout after egl init

[Marc-André Lureau]

Hi

----- Original Message -----
> Hi,
> 
> On Tue, 2016-03-22 at 13:57 +0100, Marc-André Lureau wrote:
> > Once the egl/GL context are initialized, check if there is a scanout
> > to
> > associate to display widget. This solves races when scanout update is
> > happening before the egl/GL context is ready.
> > 
> Is it common that the display channel has the scanout before the widget
> is initialized ? What about adding a debug when it happens?

Let say it is not uncommon ;) Sure let's have a debug message there.

> 
> > Signed-off-by: Marc-André Lureau <marcandre.lureau at gmail.com>
> > ---
> >  src/spice-widget-egl.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/src/spice-widget-egl.c b/src/spice-widget-egl.c
> > index 8ac3b90..d6f436d 100644
> > --- a/src/spice-widget-egl.c
> > +++ b/src/spice-widget-egl.c
> > @@ -273,6 +273,11 @@ end:
> >  
> >      d->egl.context_ready = TRUE;
> >  
> > +    if (spice_display_get_gl_scanout(SPICE_DISPLAY_CHANNEL(d-
> > >display))) {
> I prefer explicit comparison to NULL
> > +        spice_display_widget_gl_scanout(display);
> > +        spice_display_widget_update_monitor_area(display);
> > +    }
> > +
> >      return TRUE;
> >  }
> >  
> 
> Thanks,
> Pavel
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
>