[Spice-devel] [spice-common v4 3/7] log: Use glib for logging

[Jeremy White]

On 03/24/2016 10:20 AM, Christophe Fergeau wrote:
> Hey,
> 
> Sorry, hadn't noticed this message earlier.
> 
> On Wed, Mar 09, 2016 at 01:43:14PM -0600, Jeremy White wrote:
>> I realize I'm rather late to the party, but this change causes
>> troubles with Xspice.
>> 
>> That is, Xorg, on startup, closes stdout.
>> 
>> Since the g_log_default_handler writes to stdout for DEBUG and
>> INFO messages, those messages never show up anywhere.
> 
> Ah, and this worked before because all messages wer output to
> stderr
> 
>> 
>> The attached patch 'fixes' it.  I'm a bit hesitant to pursue
>> this approach; I do not know if using stdout will have a negative
>> side effect on the Xorg server.
>> 
>> Anyone else have insight?  I'll more formally submit this if I
>> don't hear anything back.
> 
> An alternative would be to use g_log_set_default_handler()

The current log.c/spice_logger() code invokes g_log_default_handler ()
directly, so setting our own default handler does no good.

That would work if we did not set up spice_logger() as a handler; it's
not entirely clear to me why we need to do that.

Cheers,

Jeremy